feat(web-ui): add an Open action to installed MiniApp listings - #1929
Merged
Conversation
The market detail modal ended installed apps on a disabled "Installed" button, so there was no way to launch an app from the market and the update state was easy to miss. - show "Installed" as an inert status line and give the primary slot to a new Open action that focuses (or opens) the app's scene tab - keep Update as the primary action when a newer release exists, with Open demoted to secondary - shorten the update label to "Update" and add the "Open" string across en-US, zh-CN, and zh-TW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
market.detail.openstring in en-US, zh-CN, and zh-TWAction row per state (primary is rightmost):
Type and Areas
Type: UI/UX
Areas: web UI (MiniApp market), locales
Motivation / Impact
The market detail modal previously ended installed apps on a disabled primary button labelled "Installed" — carrying a refresh icon it could not act on. There was no way to open an installed app from the market, so the flow dead-ended and users had to switch to the Installed tab to launch what they had just been reading about. The update state also had to compete with that inert button for attention.
Open reuses the same scene routing as a fresh install: it closes the modal and activates the existing
miniapp:<appId>tab, or opens one when absent. Like Install/Update, it stays disabled when the app requires{workspace}in a remote workspace.Verification
pnpm run type-check:web— passpnpm --dir src/web-ui exec eslint src/app/scenes/miniapps/views/MiniAppMarketView.tsx— passpnpm run i18n:contract:test— 37 passed, 0 failedpnpm run i18n:audit— passed with 0 warningsReviewer Notes
Market grid cards still show no install state: card data comes from the listing payload, and install status is resolved per-listing only when the detail modal opens. Badging cards as installed/updatable would need a batch status lookup, so it is left out of this PR.
Checklist